PICARD-3235: fingerprint column shows both icon and text, and doesn't honor fixed size#3100
Merged
phw merged 2 commits intometabrainz:masterfrom Mar 20, 2026
Merged
Conversation
When a fixed size column is displayed at the end, it is enlarged because stretchLastSection is set to True for last column. We can't do much about that, but that's not really an issue. Though when a new column is added, it doesn't return to its fixed size, and since it cannot be resized that's a problem. So to fix that, after _refresh_header_labels updates the column count and syncs visibility, it now re-applies the fixed width for non-resizeable columns. This handles the case where the fingerprint column was stretched by stretchLastSection (because it was last), and then a new column is added after it — the fingerprint column snaps back to its 18px icon size.
zas
changed the title
phw
approved these changes
Mar 20, 2026
Member
phw
left a comment
phw
left a comment
There was a problem hiding this comment.
Thanks for the fix. I tested and it works as expected. Code looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
IconColumnhas a fixed size and should only display an icon, though it displays the title, enlarging the column.Solution
Instead of displaying the text, display a tooltip.
Also fix another tricky issue when such column (fixed size) is displayed as last section: it is stretched as all columns in this position, but when losing its position, because a new column is added for example, it keeps its enlarged size and it cannot be resized (because fixed-size column). So workaround this by re-applying the fixed size on such columns.
AI Usage
In accordance with the AI use policy portion of the MetaBrainz Contribution Guidelines, the level of AI/LLM use in the development of this Pull Request is:
Action
Additional actions required: